Coverity error reader: /pacemaker/lib/common/remote.c

1    	/*
2    	 * Copyright 2008-2026 the Pacemaker project contributors
3    	 *
4    	 * The version control history for this file may have further details.
5    	 *
6    	 * This source code is licensed under the GNU Lesser General Public License
7    	 * version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
8    	 */
9    	
10   	#include <crm_internal.h>
11   	#include <crm/crm.h>
12   	
13   	#include <sys/param.h>
14   	#include <stdio.h>
15   	#include <sys/types.h>
16   	#include <sys/stat.h>
17   	#include <unistd.h>
18   	#include <sys/socket.h>
19   	#include <arpa/inet.h>
20   	#include <netinet/in.h>
21   	#include <netinet/ip.h>
22   	#include <netinet/tcp.h>
23   	#include <netdb.h>
24   	#include <stdlib.h>
25   	#include <errno.h>
26   	#include <inttypes.h>   // PRIu32, PRIx32
27   	
28   	#include <glib.h>
29   	#include <bzlib.h>
30   	
31   	#include <crm/common/ipc_internal.h>
32   	#include <crm/common/xml.h>
33   	#include <crm/common/mainloop.h>
34   	#include <crm/common/remote_internal.h>
35   	
36   	#ifdef HAVE_GNUTLS_GNUTLS_H
37   	#  include <gnutls/gnutls.h>
38   	#endif
39   	
40   	/* Swab macros from linux/swab.h */
41   	#ifdef HAVE_LINUX_SWAB_H
42   	#  include <linux/swab.h>
43   	#else
44   	/*
45   	 * casts are necessary for constants, because we never know how for sure
46   	 * how U/UL/ULL map to __u16, __u32, __u64. At least not in a portable way.
47   	 */
48   	#define __swab16(x) ((uint16_t)(                                      \
49   	        (((uint16_t)(x) & (uint16_t)0x00ffU) << 8) |                  \
50   	        (((uint16_t)(x) & (uint16_t)0xff00U) >> 8)))
51   	
52   	#define __swab32(x) ((uint32_t)(                                      \
53   	        (((uint32_t)(x) & (uint32_t)0x000000ffUL) << 24) |            \
54   	        (((uint32_t)(x) & (uint32_t)0x0000ff00UL) <<  8) |            \
55   	        (((uint32_t)(x) & (uint32_t)0x00ff0000UL) >>  8) |            \
56   	        (((uint32_t)(x) & (uint32_t)0xff000000UL) >> 24)))
57   	
58   	#define __swab64(x) ((uint64_t)(                                      \
59   	        (((uint64_t)(x) & (uint64_t)0x00000000000000ffULL) << 56) |   \
60   	        (((uint64_t)(x) & (uint64_t)0x000000000000ff00ULL) << 40) |   \
61   	        (((uint64_t)(x) & (uint64_t)0x0000000000ff0000ULL) << 24) |   \
62   	        (((uint64_t)(x) & (uint64_t)0x00000000ff000000ULL) <<  8) |   \
63   	        (((uint64_t)(x) & (uint64_t)0x000000ff00000000ULL) >>  8) |   \
64   	        (((uint64_t)(x) & (uint64_t)0x0000ff0000000000ULL) >> 24) |   \
65   	        (((uint64_t)(x) & (uint64_t)0x00ff000000000000ULL) >> 40) |   \
66   	        (((uint64_t)(x) & (uint64_t)0xff00000000000000ULL) >> 56)))
67   	#endif
68   	
69   	#define REMOTE_MSG_VERSION 1
70   	#define ENDIAN_LOCAL 0xBADADBBD
71   	
72   	struct remote_header_v0 {
73   	    uint32_t endian;    /* Detect messages from hosts with different endian-ness */
74   	    uint32_t version;
75   	    uint64_t id;
76   	    uint64_t flags;
77   	    uint32_t size_total;
78   	    uint32_t payload_offset;
79   	    uint32_t payload_compressed;
80   	    uint32_t payload_uncompressed;
81   	
82   	        /* New fields get added here */
83   	
84   	} __attribute__ ((packed));
85   	
86   	/*!
87   	 * \internal
88   	 * \brief Retrieve remote message header, in local endianness
89   	 *
90   	 * Return a pointer to the header portion of a remote connection's message
91   	 * buffer, converting the header to local endianness if needed.
92   	 *
93   	 * \param[in,out] remote  Remote connection with new message
94   	 *
95   	 * \return Pointer to message header, localized if necessary
96   	 */
97   	static struct remote_header_v0 *
98   	localized_remote_header(pcmk__remote_t *remote)
99   	{
100  	    struct remote_header_v0 *header = NULL;
101  	    size_t expected_size = 0;
102

(1) Event path:	Condition "remote == NULL", taking false branch.
(2) Event path:	Condition "remote->buffer == NULL", taking false branch.
(3) Event path:	Condition "remote->buffer_offset < 40UL /* sizeof (struct remote_header_v0) */", taking false branch.

103  	    if ((remote == NULL) || (remote->buffer == NULL)
104  	        || (remote->buffer_offset < sizeof(struct remote_header_v0))) {
105  	
106  	        // Caller error or we haven't received the full header yet
107  	        return NULL;
108  	    }
109  	
110  	    header = (struct remote_header_v0 *) remote->buffer;

(4) Event path:

Condition "header->endian != 3134905277U", taking true branch.

111  	    if (header->endian != ENDIAN_LOCAL) {
112  	        uint32_t endian = __swab32(header->endian);
113

(5) Event path:

Condition "!(endian == 3134905277U)", taking false branch.

114  	        CRM_LOG_ASSERT(endian == ENDIAN_LOCAL);

(6) Event path:

Condition "endian != 3134905277U", taking false branch.

115  	        if(endian != ENDIAN_LOCAL) {
116  	            crm_err("Invalid message detected, endian mismatch: %" PRIx32
117  	                    " is neither %" PRIx32 " nor the swab'd %" PRIx32,
118  	                    ENDIAN_LOCAL, header->endian, endian);
119  	            return NULL;
120  	        }
121

(7) Event path: